Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor field component test file to new format #3434

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Nov 21, 2024

What is the context of this PR?

Fixes #155 in the design team issues board

Refactors the Field component test file to the new agreed format

How to review this PR

Run tests locally and check that the messages make sense and describe what is being tested

Ask yourself....

  • Do we need any additional tests?
  • Are the tests descriptions clear?
  • Does the order of the test document make sense?
  • Is it internally consistent?
  • Is it consistent with the guidelines for test refactoring?
  • run this test command to view the test results:
  • yarn test --testNamePattern="FOR: Macro: Field"

Checklist

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Tech improvements Tech debt, cleanup, code standardisation etc. label Nov 21, 2024
@rmccar rmccar self-assigned this Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 836de28
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6745d5c6166bd50008707b64
😎 Deploy Preview https://deploy-preview-3434--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar changed the title Refactor field component test file Refactor field component test file to new format Nov 22, 2024
@rmccar rmccar merged commit d8f4555 into main Nov 26, 2024
25 checks passed
@rmccar rmccar deleted the refactor-field-component-test-file branch November 26, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing refactor - Field
3 participants